feat: precommit pyright basic type-checking #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside the devcontainer vscode is using pyright with basic typechecking which finds some errors mypi currently doesn't find (some of them probably by configuration, as the results should be similar). This commit adds pyright to precommit which currently finds the errors at the end of this message.
Some of them can probably to be ignored by comments but for example:
could be an wrong casting to str.
If you are happy with mypy i would like to disable pyright in the dev-container and enably mypy with an vscode extension, otherwise I would just ignore or fix these errors and merge this. Either way it is worth to look some of them up.
What is your opinion?
OT: mypy check is currently failing on main