BUG/MEDIUM: edge: avoid setting state until success #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was recently reported by @sloh-fastly that if a `sigsci_edge_deployment` was created without a `sigsci_site` it appeared to have been created within Terraform state. This caused some weird inconsistencies and could lead to the below error: ``` Error: Provider produced inconsistent result after apply When applying changes to sigsci_site.acme_nginx_waf["stg"], provider "provider[\"registry.terraform.io/signalsciences/sigsci\"]" produced an unexpected new value: Root resource was present, but now absent. This is a bug in the provider, which should be reported in the provider's own issue tracker. ``` Shu provided a thorough outline to reproduce, unfortunately I was not able to reproduce. However, I was able to identify what I believe to be happening. It seemed that even though the `sigsci_edge_deployment` was failing it was being populated into the terraform.tfstate file with a "tainted" status attached. It was found that the provider was prematurely calling `d.SetId()` without first checking if an error had occurred. This was causing Terraform to believe that it at least partially succeeded warranting it to be in a tainted state. This commit moves `d.SetId()` to only be called if the calls to `CreateOrUpdateEdgeDeployment()` and `CreateOrUpdateEdgeDeploymentService` were sucessful. This fixes the underlying issue and avoids populating the Terraform state with tainted versions of `sigsci_edge_deployment` and `sigsci_edge_deployment_service` if an error occurred.
shawnps
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recently reported by @sloh-fastly that if a
sigsci_edge_deploymentwas created without asigsci_siteit appeared to have been created within Terraform state. This caused some weird inconsistencies and could lead to the below error:Shu provided a thorough outline to reproduce, unfortunately I was not able to reproduce. However, I was able to identify what I believe to be happening. It seemed that even though the
sigsci_edge_deploymentwas failing it was being populated into the terraform.tfstate file with a "tainted" status attached.It was found that the provider was prematurely calling
d.SetId()without first checking if an error had occurred. This was causing Terraform to believe that it at least partially succeeded warranting it to be in a tainted state.This commit moves
d.SetId()to only be called if the calls toCreateOrUpdateEdgeDeployment()andCreateOrUpdateEdgeDeploymentServicewere sucessful.This fixes the underlying issue and avoids populating the Terraform state with tainted versions of
sigsci_edge_deploymentandsigsci_edge_deployment_serviceif an error occurred.