Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_logfile maximum-rotate does'nt work #2414

Open
ilkayorhanlar opened this issue Apr 2, 2024 · 4 comments · May be fixed by #2440
Open

mod_logfile maximum-rotate does'nt work #2414

ilkayorhanlar opened this issue Apr 2, 2024 · 4 comments · May be fixed by #2440
Labels
bug Something isn't working

Comments

@ilkayorhanlar
Copy link

I set maximum-rotate with 500 in logfile.conf but I did'nt see 500 files in log path. I see 91 log files. My expectation is that I can see 500 log file in log path. But I guess that freeswitch removes log files.

Notes:
I restart freeswitch each early morning.
I run this command with cron for each 6 hours to rotate logs (systemctl kill -s HUP freeswitch)

FreeSWITCH Version 1.10.9-release.15~64bit (-release.15 64bit)
CentOS Linux release 7.9.2009 (Core)

@ilkayorhanlar ilkayorhanlar added the bug Something isn't working label Apr 2, 2024
@ilkayorhanlar ilkayorhanlar changed the title mod_logfile maximum-rotate does'nt works mod_logfile maximum-rotate does'nt work Apr 2, 2024
@ilkayorhanlar
Copy link
Author

I guess, in mod_logfile.c file and in "load_profile" method" method suffix variable is equaled to 1. I guess after freeswitch restart, be called "load_profile" method in "mod_logfile.c"

But my opinion;
If suffix of my oldest log file is 90, suffix variable should be 90.

In this way, the rotation logic doesnt effect restart operation.

If you agree with me, I can open pull request.

@omercurgul
Copy link

I know this problem. I have been living too for a long time. It would be nice if there is a solution and it is fixed.

Can you help with the solution?

@ilkayorhanlar
Copy link
Author

PR #2440

@omercurgul
Copy link

Thanks. I hope they merge it into the main repo quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants