Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1x1 video layout produces 1x2 #955

Closed
David-dp- opened this issue Nov 18, 2020 · 4 comments
Closed

1x1 video layout produces 1x2 #955

David-dp- opened this issue Nov 18, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@David-dp-
Copy link

Describe the bug
When we configure getUserMedia to send 320x240 (using recent Chrome), and then in our FS 1.10.5 dialplan we forward that as rtmp this way...

<action application="record_session" data="{modname=mod_av,vw=320,vh=240}rtmp://mydomain.com"/>

...an ffmpeg capture reveals the user video to be only a 160x120 inset (against the left margin and centered vertically). The rest of the frame is black. It seems like a 2-person conference layout (and we are using a conference with a virtual agent with setting 'mintwo'. Our conference profile has:

  <param name="video-mode" value="mux"/>
  <param name="video-layout-name" value="1x1"/>
  <param name="video-canvas-size" value="320x240"/>
  <param name="max-members" value="2"/>

To Reproduce
Steps to reproduce the behavior:

  1. Use the example configuration above
  2. Arrange to capture and record the rtmp received
  3. Dial into conference using verto
  4. Note the layout in the recorded rtmp
  5. Change video-mode to 'transcode' following https://freeswitch.org/confluence/display/FREESWITCH/mod_conference Note that the 160x120 frame is now shown twice in the middle of the screen (vertically), still not 1x1.

Expected behavior
The recorded rtmp should show the verto user fullscreen.

Package version or git hash

  • Version 1.10.5
@David-dp- David-dp- added the bug Something isn't working label Nov 18, 2020
@David-dp-
Copy link
Author

David-dp- commented Nov 23, 2020

@seven1240 responded in the users list: "did you happen to set record_concat_video etc ? or maybe try conference record"

Yes, we already use both of those...

<action application="set" data="core_video_blank_image=false"/>
<action application="lua" data="${conf_dir}/dialplan/answer_then_ensure_sip_encryption.lua ${extension}"/>
<action application="set" data="record_concat_video=true"/>
<action application="set" data="jitterbuffer_msec=5p:100p"/>
<action application="set" data="RECORD_MIN_SEC=2"/>
<action application="set" data="RECORD_STEREO=true"/>
<action application="set" data="record_sample_rate=44100"/>
<action application="set" data="video_no_video_avatar_png=${conf_dir}/dialplan/YourComputerStoppedSendingUsVideo-PleaseCallBack.png"/>
<condition field="${codeForDesiredExperience}" expression="v-1" require-nested="false" break="never">
    <action application="set" data="maxSecondsToConnectToVA=3"/>
    <action application="log" data="INFO Start streaming to VA"/>
    <action application="curl" data="http://mydomain.com connect-timeout ${maxSecondsToConnectToVA} post"/>
    <action application="record_session" data="{modname=mod_av,vw=320,vh=240}rtmp://mydomain.com"/>
</condition>
<condition break="never">
    <action application="set" data="conference_auto_outcall_skip_member_beep=true"/>
    <action application="set" data="api_hangup_hook=jsrun ${conf_dir}/dialplan/cleanup.js ${idOfClientSession} ${codeForDesiredExperience} ${ipOfVA} ${ipOfRestfuldb}"/>
    <action application="set" data="session_in_hangup_hook=true"/>
    <action application="set" data="conference_auto_record=$${recordings_dir}/${mp4_filename}"/>
    <action application="conference_set_auto_outcall"
            data="['conference_member_flags=endconf,jitterbuffer_msec=5p:100p']sofia/gateway/asterisk/${my_destination}"/>
    <action application="conference" data="${my_destination}@my_conference+flags{endconf|mintwo|join-vid-floor}"/>
</condition>

Should we use something different?

I haven't been able to find where in the source the video layout is applied; if someone would provide a link into the repo, I'd dig deeper.

@seven1240
Copy link
Collaborator

it's not a bug! I already told you on the mailing list to turn off the video concat or use conference record

@David-dp-
Copy link
Author

Thank you for this advice @seven1240 When you asked in the mailing list whether we were using those two settings, it wasn't clear to me whether we should or should not use them.

We commented-out <action application="set" data="record_concat_video=true"/> and verified that our rtmp outbound stream now has the one user fullscreen.

There is no documentation about record_concat_video on FS confluence nor by Googling, so this issue may be a valuable reference to others.

@seven1240
Copy link
Collaborator

seven1240 commented Dec 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants