add the ability to force mentions to be rendered on top of the input #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/signavio/react-mentions/a5c1mv989 |
Bilb
added a commit
to oxen-io/session-desktop
that referenced
this pull request
Nov 27, 2020
this can be reverted once signavio/react-mentions#449 is merged upstream, as the DefinitelyTyped types will be regenerated
Bilb
added a commit
to Bilb/session-desktop
that referenced
this pull request
Nov 27, 2020
this can be reverted once signavio/react-mentions#449 is merged upstream, as the DefinitelyTyped types will be regenerated
Bilb
added a commit
to oxen-io/session-desktop
that referenced
this pull request
Nov 27, 2020
this can be reverted once signavio/react-mentions#449 is merged upstream, as the DefinitelyTyped types will be regenerated
|
Any updates on this @jfschwarz ? |
|
Any updates on this @jfschwarz ? What can I do to get this merged? |
jfschwarz
approved these changes
May 20, 2021
|
@jfschwarz thanks for accepting the PR. I made the PR to update the types too and I think it needs a package maintainer approval for it to be merged: DefinitelyTyped/DefinitelyTyped#53353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mentions can be rendered on top of the input/textarea only if the space below is not enough.
For my usecase, I wanted the mentions to be rendered on top of it always. So I added a boolean to do this.