fix: fixes scroll into view in custom container elements #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 931744f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khamiltonuk
approved these changes
May 31, 2023
steffektif
approved these changes
May 31, 2023
steffektif
reviewed
May 31, 2023
steffektif
reviewed
May 31, 2023
Co-authored-by: Stef ❤️ <stefan.herz@sap.com>
Sigrsig
added a commit
that referenced
this pull request
Jun 1, 2023
* custom suggestions container revised to allow scrolling * changeset added * Update .changeset/smart-eyes-kiss.md Co-authored-by: Stef ❤️ <stefan.herz@sap.com> --------- Co-authored-by: Stef ❤️ <stefan.herz@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: 674
What did you change (functionally and technically)?
When attempting to scroll through the custom container elements an error would occur. I found that the custom container was being rendered inside the unordered list instead of around it. Rearranged the elements
Checklist (remove this list before you submit the PR)
How to test:
maxHeightandoverflowY: 'auto'to the list styling in SuggestionsOverlay.jsupanddownbuttons