Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown location #695

Closed
wants to merge 2 commits into from
Closed

Fix dropdown location #695

wants to merge 2 commits into from

Conversation

Sigrsig
Copy link
Collaborator

@Sigrsig Sigrsig commented Jun 29, 2023

Fixes issue where dropdown will appear in previous caret position when clicking next to an @ symbol

What did you change (functionally and technically)?

  • conditional statement that would cause the caret position not to update correctly removed

How to test:

  • select a text box and type an @ symbol
  • click somewhere else in the text box to move the caret
  • click back on the @ symbol
  • Expected: Dropdown should appear by the @ symbol

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023

🦋 Changeset detected

Latest commit: 2f0f67f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-mentions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-mentions ✅ Ready (Inspect) Visit Preview Jun 29, 2023 2:28pm

@Sigrsig Sigrsig marked this pull request as ready for review June 29, 2023 14:36
@Sigrsig Sigrsig closed this Jun 30, 2023
@Sigrsig Sigrsig deleted the fix-dropdown-location branch June 30, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant