Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/improve specs #152

Merged
merged 6 commits into from Sep 17, 2020
Merged

Improvement/improve specs #152

merged 6 commits into from Sep 17, 2020

Conversation

frontendphil
Copy link
Contributor

@frontendphil frontendphil commented Sep 17, 2020

  • remove all those callbacks from the specs
  • use @testing-library/react in specs
  • add flow-types to all specs

@vercel
Copy link

vercel bot commented Sep 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/signavio/react-stick/njepx8sr7
✅ Preview: https://react-stick-git-improvement-imrpove-specs.signavio.vercel.app

@codecov-commenter
Copy link

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          13       13           
  Lines         282      282           
=======================================
  Hits          271      271           
  Misses         11       11           
Impacted Files Coverage Δ
src/StickNode.js 100.00% <ø> (ø)
src/Stick.js 92.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de83389...44fce63. Read the comment docs.

@frontendphil frontendphil merged commit c339d22 into master Sep 17, 2020
@frontendphil frontendphil deleted the improvement/imrpove-specs branch September 17, 2020 14:14
@workflow-bot
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants