Merge pull request #134 from signmeup/hotfix/dont-show-online-students

Hotfix: display only online TAs, not students, on queue page
signmeup · Nov 22, 2016 · fbda673 · fbda673
2 parents abb2f38 + 60ce17f
commit fbda673
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/app/imports/ui/components/queue-header/queue-header.html b/app/imports/ui/components/queue-header/queue-header.html
@@ -6,7 +6,7 @@
         <div class="name-and-staff">
           <h1 class="queue-name display-5 mb-1">{{queue.course.name}} &middot; {{queue.name}}</h1>
           <div class="staff float-xs-right">
-            {{#each ta in onlineStaff}}
+            {{#each ta in (onlineStaff queue)}}
               {{> ProfilePic user=ta}}
             {{/each}}
           </div>

diff --git a/app/imports/ui/components/queue-header/queue-header.js b/app/imports/ui/components/queue-header/queue-header.js
@@ -25,14 +25,16 @@ Template.QueueHeader.helpers({
   ticketCount,
   scheduledEndTime,
 
-  onlineStaff() {
-    const staff = Meteor.users.find({
+  onlineStaff(queue) {
+    const staff = queue.course().staff().fetch();
+    const onlineStaff = Meteor.users.find({
+      _id: { $in: staff.map((user) => { return user._id; }) },
       'status.online': true,
-    }).fetch();
+    });
 
     const online = [];
     const idle = [];
-    staff.forEach((user) => {
+    onlineStaff.forEach((user) => {
       if (user.status.idle) {
         idle.push(user);
       } else {