Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing Link Expiration does not accept null #22

Closed
matthewhutchings opened this issue Sep 14, 2022 · 2 comments
Closed

Signing Link Expiration does not accept null #22

matthewhutchings opened this issue Sep 14, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@matthewhutchings
Copy link

matthewhutchings commented Sep 14, 2022

as per documentation:

In your request specify: "auth_method" - signer authentication menthod; can be "password", "email", "mfa", "social", "biometric", "other", "none" "link_expiration" - in how many minutes the link expires, ranges from 15 to 45 minutes or null.
https://docs.signnow.com/docs/signnow/aaa2c15d291c3-generate-a-link-for-embedded-invite

However:

   public function setSigningLinkExpiration(
        string $documentUid,
        string $fieldInviteUniqueId,
        int $expiration,
        ?AuthMethodInterface $authMethod = null
    ) {

int $expiration should allow null

@darnel868
Copy link

Did this problem fix?

@JiSoft JiSoft added the bug Something isn't working label Sep 27, 2022
JiSoft added a commit that referenced this issue Sep 28, 2022
@JiSoft
Copy link
Contributor

JiSoft commented Sep 28, 2022

Fixed at
v2.2.3
v1.5.3

@JiSoft JiSoft closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants