Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to gets assets by account ownership #727

Closed
ipr0310 opened this issue Mar 6, 2023 · 4 comments
Closed

Allow to gets assets by account ownership #727

ipr0310 opened this issue Mar 6, 2023 · 4 comments
Labels
API Issues related to the Node's API enhancement New feature or request

Comments

@ipr0310
Copy link
Member

ipr0310 commented Mar 6, 2023

Describe the solution you'd like
As the new incoming Signum Node Version will include a new transaction type Token Ownership Transfer adjustments are necessary.
Is necessary to add support for getting the assets only owned by an account, not the issued ones.

What i mean with ownership is that the account is able to do basic token operations like: Minting, Treasury account management, etc...

It would look something like this:
image

Additional Context
There is the possibility to get assets by issuer (getAssetsByIssuer) but not by ownership.

Alternative option
Is possible to get the assets an account Has ownership of by just making a getAssetsByIssuer request and filter it client-side.
But by the time the chain grows, efficiency is still key.

@ipr0310 ipr0310 added enhancement New feature or request API Issues related to the Node's API labels Mar 6, 2023
@frankTheTank72
Copy link
Member

@jjos2372 the current call /api?requestType=getAssetsByIssuer is not returning the correct account ( always the issuer) - can you adjust the output like on getAsset please

@jjos2372
Copy link

jjos2372 commented Mar 6, 2023

Should we create a new end point like getAssetsByOwner as suggested or just extend this one and make getAssetsByIssuer to return both, issued and owned?

@frankTheTank72
Copy link
Member

frankTheTank72 commented Mar 6, 2023

i would think it is more clear to have getAssetsByOwner and getAssetsByIssuer

jjos2372 added a commit that referenced this issue Mar 6, 2023
@frankTheTank72
Copy link
Member

@ipr0310 fixed with beta2 and also new getAssetsByOwner

@jjos2372 jjos2372 closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to the Node's API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants