Update dockerhub gh action to push a single image #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to make it per db anymore...? |
|
No, I figure we can just push the one image and default it to sqlite, then the user can configure it manually to something else if they want. |
ohager
approved these changes
Jun 22, 2024
| type=semver,pattern={{version}}-h2 | ||
| type=raw,value=latest-h2 | ||
| type=semver,pattern={{version}} | ||
| type=raw,value=latest | ||
| flavor: | | ||
| latest=false | ||
|
|
||
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@v2 |
There was a problem hiding this comment.
there's a v5 out there.... we should it give a chance
|
merging without v5 upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the second image publish and modified the first to build and push a single image to dockerhub using the Dockerfile in the main folder. Give it a try and see if it works, and if it does, consider uncommenting the "on release" option.