Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topics #183

Merged
merged 1 commit into from
May 15, 2023
Merged

Remove topics #183

merged 1 commit into from
May 15, 2023

Conversation

emhane
Copy link
Collaborator

@emhane emhane commented May 12, 2023

Description

Remove topics in alignment with version 5.2 specs.

Notes & open questions

Change checklist

  • Self-review
  • Documentation updates if relevant
  • Tests if relevant

Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :). Thanks

@divagant-martian divagant-martian merged commit 2216dd6 into sigp:master May 15, 2023
6 checks passed
@emhane emhane deleted the remove-topic branch May 15, 2023 04:38
@emhane
Copy link
Collaborator Author

emhane commented May 15, 2023

I see I based this on master and not discv5.2, I will merge master into discv5.2 when I am done with the NAT PR, or vv. These things are left to implement on discv5.2 ethereum/devp2p#226.

@emhane emhane restored the remove-topic branch May 19, 2023 17:09
@emhane emhane mentioned this pull request May 19, 2023
3 tasks
@emhane emhane deleted the remove-topic branch May 22, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants