New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exit verification at fork boundaries #4184
Comments
I think the signature check is OK actually, because it uses the exit's internal epoch: lighthouse/consensus/state_processing/src/per_block_processing/signature_sets.rs Lines 390 to 395 in a53830f
But the other checks relative to current epoch are liable to fail, e.g. lighthouse/consensus/state_processing/src/per_block_processing/verify_exit.rs Lines 46 to 53 in a53830f
Plumbing an optional wall-clock epoch into |
I've started working on a fix in #4183, so we might not need this issue after all. |
## Issue Addressed NA ## Proposed Changes Similar to #4181 but without the version bump and a more nuanced fix. Patches the high CPU usage seen after the Capella fork which was caused by processing exits when there are skip slots. ## Additional Info ~~This is an imperfect solution that will cause us to drop some exits at the fork boundary. This is tracked at #4184.~~
Closed by #4183 |
## Issue Addressed NA ## Proposed Changes Similar to sigp#4181 but without the version bump and a more nuanced fix. Patches the high CPU usage seen after the Capella fork which was caused by processing exits when there are skip slots. ## Additional Info ~~This is an imperfect solution that will cause us to drop some exits at the fork boundary. This is tracked at sigp#4184.~~
## Issue Addressed NA ## Proposed Changes Similar to sigp#4181 but without the version bump and a more nuanced fix. Patches the high CPU usage seen after the Capella fork which was caused by processing exits when there are skip slots. ## Additional Info ~~This is an imperfect solution that will cause us to drop some exits at the fork boundary. This is tracked at sigp#4184.~~
Description
In #4183 we made a patch to fix high CPU usage for exit verification across skip slots.
This patch doesn't cover the case where we receive an exit for epoch
E + 1
when the head state is in epochE
and those two epochs are across a fork boundary.The text was updated successfully, but these errors were encountered: