Convert amcl to a submodule #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirk Baird <baird.k@outlook.com>
Signed-off-by: Kirk Baird <baird.k@outlook.com>
Signed-off-by: Kirk Baird <baird.k@outlook.com>
Signed-off-by: Kirk Baird <baird.k@outlook.com>
paulhauner
reviewed
Jan 9, 2020
src/aggregates.rs
Outdated
| @@ -225,7 +199,11 @@ impl AggregateSignature { | |||
| I: Iterator<Item = (G2Point, Vec<G1Point>, Vec<Vec<u8>>, u64)>, | |||
| { | |||
| let mut final_agg_sig = GroupG2::new(); // Aggregates AggregateSignature | |||
| let mut rhs_pairs: Vec<AtePair> = vec![]; // e(H(1,1), P(1,1)), e(H(1,2), P(1,2)), ..., e(H(n,m), P(n,m)) | |||
| //let mut rhs_pairs: Vec<AtePair> = vec![]; // e(H(1,1), P(1,1)), e(H(1,2), P(1,2)), ..., e(H(n,m), P(n,m)) | |||
|
Looks like cargofmt is unhappy too |
Signed-off-by: Kirk Baird <baird.k@outlook.com>
Signed-off-by: Kirk Baird <baird.k@outlook.com>
Fixed :) |
paulhauner
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it seems the amcl files had been copied directly from the old Apache Milagro repo which has since been deleted.
This PR would instead use a SigP fork of the new Repo as a submodule.
It will make it far easier to pull changes and make changes to the AMCL repo.
I could not see any major changes to the files other than the director structures and running
cargo fmt.