Rename deprecated constant kIOMasterPortDefault #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constant is now deprecated since macOS 12.0 and a new constant named kIOMainPortDefault is provided. There is a fallback in place that retains compatibility for older macOS versions. https://developer.apple.com/documentation/iokit/kiomasterportdefault
|
Good idea! I see you borrowed the implementation from kovidgoyal/kitty#3719 BTW do you know how on earth one can create an account over at Sigrok Bugzilla? There's this bug where the Silabs CP210x USB to serial chip series can't be used with libserialport, which is a real bummer. |
I can’t seem to find it after a quick look. Maybe you need to contact them on the IRC channel. At lest for the wiki part that seems to be the case. They state if you want to contribute you can request an account on their IRC. |
|
Merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant is now deprecated since macOS 12.0 and a new constant named kIOMainPortDefault is provided.
There is a fallback in place that retains compatibility with older macOS versions.
This removes the warnings when compiling the library on modern systems, and makes sure the library will keep working on future versions of the OS.
https://developer.apple.com/documentation/iokit/kiomasterportdefault
https://developer.apple.com/documentation/iokit/kiomainportdefault