Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decoder: signature analysis #19

Closed
wants to merge 1 commit into from
Closed

Add decoder: signature analysis #19

wants to merge 1 commit into from

Conversation

sharow
Copy link
Contributor

@sharow sharow commented Oct 7, 2019

It is HP's troubleshooting tools.

specification is patented. it is expired now.
https://patents.google.com/patent/US4991175A/en

detail about the Signature Analysis:
https://www.hpl.hp.com/hpjournal/pdfs/IssuePDFs/1977-05.pdf

sigrok WIKI page draft:
https://hackmd.io/@tEk2WdkmQxG8SHsmxaIqQg/Hke6dUG_H

related PR:

@uwehermann
Copy link
Member

Hi, sorry for the delay! Merged in 112a264 with a few small whitespace/cosmetic changes squashed-in, thanks a lot!

Added a few commits on top which fix a few additional smaller things.

I've changed the license metadata field to reflect what the license header in pd.py says (GPLv2+), but if you prefer GPLv3+ please feel free to change both accordingly.

I've also grabbed most of the content from your wiki page draft, thanks a lot! Page is here:
https://sigrok.org/wiki/Protocol_decoder:Signature

Is Public Domain fine with you for the content and the PulseView screenshot?

We can't use screenshots from HP manual (or other photos which are not self-made) since we don't own the copyright on those, so they're omitted.

Thanks again for your work on the decoder!

@uwehermann uwehermann closed this Nov 28, 2019
@sharow
Copy link
Contributor Author

sharow commented Nov 28, 2019

GPLv2+
Is Public Domain fine with you for the content and the PulseView screenshot

Of cause it's fine!

We can't use screenshots from HP manual

ya, sorry it's my mistake.

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants