Repeat retriggering #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeated triggering adds segments, split start_capture and new capture_session functions
Move settings UI into popup instead of dialog Disable button when capture is running
fixup change tooltip
Add `Starting` state in Session so the view can do one-time setup tasks before states start looping between `Running` and `Awaiting`. Update segment display logic in View
Use a common subroutine to update the current segment display in response to - new segment - segment completed - set segment display mode
|
If you are still accepting ideas, I would like an ability to repeat scans until a trigger signal stops. Then display with the normal pretrigger percentage. A sort of 'watchdog'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work by @Cenkron to add a repeating retrigger mode to PulseView capture sessions. The user can enable repeat mode and set a time delay between when each capture segment completes and the next one is starts.
In the prior email exchange, some changes were requested to better fit the UI and architecture:
https://sourceforge.net/p/sigrok/mailman/sigrok-devel/thread/cdf7c54b-c509-9162-34fb-2709f5756437%40BrianAndChristine.com/
Following these suggestions, this PR moves the retrigger timer into the session state and uses the existing feature to display segments from a repetitive capture on the same time scale.
Some draft icons are also added for new UI:
Open questions
Runningstate repeatedly. Howeverpv::views::trace::Viewexpects the transition toRunningstate to happen only once per capture and uses it as a signal to reset the state of the UI which interferes with segment display. More states can be added to the session but I don't know whether it is best to do so. See comments in view.cpp.