fix: lint warning (#557)

* fix: lint warning

Signed-off-by: Hector Fernandez <hectorf@vmware.com>

* Fix lint warnings.

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>

Co-authored-by: Dan Lorenc <lorenc.d@gmail.com>

.golangci.yml

@@ -21,7 +21,7 @@ linters:
   - goimports
   - gosec
   - gocritic
-  - golint
+  - revive
   - misspell
   - unconvert
   - unparam

Makefile

@@ -58,7 +58,7 @@ GOLANGCI_LINT = $(shell pwd)/bin/golangci-lint
 golangci-lint:
 	rm -f $(GOLANGCI_LINT) || :
 	set -e ;\
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.40.1 ;\
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.42.0 ;\
 
 lint: golangci-lint ## Runs golangci-lint linter
 	$(GOLANGCI_LINT) run  -n

cmd/cosign/cli/version.go

@@ -35,7 +35,7 @@ import (
 var (
 	// Output of "git describe". The prerequisite is that the branch should be
 	// tagged using the correct versioning strategy.
-	GitVersion string = "devel"
+	GitVersion = "devel"
 	// SHA1 from git, output of $(git rev-parse HEAD)
 	gitCommit = "unknown"
 	// State of git tree, either "clean" or "dirty"

pkg/cosign/attestation/attestation.go

@@ -77,7 +77,7 @@ func GenerateStatement(opts GenerateOpts) (interface{}, error) {
 	case "link":
 		return generateLinkStatement(rawPayload, opts.Digest, opts.Repo)
 	default:
-		return nil, errors.New(fmt.Sprintf("we don't know this predicate type: '%s'", opts.Type))
+		return nil, fmt.Errorf("we don't know this predicate type: '%s'", opts.Type)
 	}
 }