pkg/oci/remote: should handle error on name.NewRepository

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
sigstore · May 16, 2022 · 80ab7ef · 80ab7ef
1 parent 3284ba9
commit 80ab7ef
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/oci/remote/options.go b/pkg/oci/remote/options.go
@@ -127,7 +127,10 @@ func WithTargetRepository(repo name.Repository) Option {
 func GetEnvTargetRepository() (name.Repository, error) {
 	if ro := os.Getenv(RepoOverrideEnvKey); ro != "" {
 		repo, err := name.NewRepository(ro)
-		return repo, fmt.Errorf("parsing $"+RepoOverrideEnvKey+": %w", err)
+		if err != nil {
+			return name.Repository{}, fmt.Errorf("parsing $"+RepoOverrideEnvKey+": %w", err)
+		}
+		return repo, nil
 	}
 	return name.Repository{}, nil
 }