Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review unit and integration tests #1385

Open
4 tasks
priyawadhwa opened this issue Feb 1, 2022 · 3 comments
Open
4 tasks

Review unit and integration tests #1385

priyawadhwa opened this issue Feb 1, 2022 · 3 comments
Assignees
@znewman01
Labels
enhancement New feature or request

Comments

@priyawadhwa
Copy link
Contributor

priyawadhwa commented Feb 1, 2022 •
edited

Some things we could do here to make sure we have good test coverage:

  • Make sure unit tests are thorough
  • Reorganize integration tests (they're mostly in one big e2e_test.go file right now)
  • Make sure integration tests are thorough, ideally covering experimental features well & an OIDC flow (this might have already happened)
  • add a test for the second case in GHSA-ccxc-vr6p-4858 once the OIDC flow is in place.
@priyawadhwa priyawadhwa added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Feb 1, 2022
@znewman01
Copy link
Contributor

We should add a test for the second case in GHSA-ccxc-vr6p-4858 once the OIDC flow is in place.

@znewman01
Copy link
Contributor

See also: sigstore/fulcio#368

@znewman01
Copy link
Contributor

Can I tag you in, @wlynch? This seems related to some of the other Sigstore work you're doing right now and I haven't been able to find much time to devote here.

@wlynch wlynch mentioned this issue May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@znewman01 znewman01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@znewman01 @priyawadhwa