Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review test coverage of fulcio #368

Closed
priyawadhwa opened this issue Feb 1, 2022 · 1 comment
Closed

Review test coverage of fulcio #368

priyawadhwa opened this issue Feb 1, 2022 · 1 comment
Assignees
@haydentherapper
Labels
enhancement New feature or request

Comments

@priyawadhwa
Copy link
Contributor

Before going GA, it would be nice to make sure that unit tests and integration tests are thorough!
@priyawadhwa priyawadhwa added the enhancement New feature or request label Feb 1, 2022
@nsmith5 nsmith5 mentioned this issue Feb 23, 2022
Closed
@znewman01 znewman01 mentioned this issue Mar 2, 2022
Open
4 tasks
@haydentherapper
Copy link
Contributor

Going to close this. Almost every function in pkg/ has a test, even though codecov says we're at 60%ish. I'm happy with the level of coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haydentherapper haydentherapper

Labels
enhancement New feature or request
Projects
Sigstore GA
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haydentherapper @priyawadhwa