Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oci.Signature() method to expose raw signature #2517

Closed
haydentherapper opened this issue Dec 6, 2022 · 0 comments · Fixed by #2628
Closed

Add oci.Signature() method to expose raw signature #2517

haydentherapper opened this issue Dec 6, 2022 · 0 comments · Fixed by #2628
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@haydentherapper
Copy link
Contributor

Description

Context: #2499

We need the raw signature for timestamping, so we have to fetch the base64 encoding signature and decode it. We should just expose the raw signature in the OCI struct.

cc @znewman01
@haydentherapper haydentherapper added the enhancement New feature or request label Dec 6, 2022
@haydentherapper haydentherapper mentioned this issue Dec 6, 2022
Merged
@haydentherapper haydentherapper added the good first issue Good for newcomers label Dec 6, 2022
mozillazg added a commit to mozillazg/cosign that referenced this issue Jan 15, 2023
@mozillazg
Add oci.Signature() method to expose raw signature
18e9432 
Closes sigstore#2517

Signed-off-by: mozillazg <mozillazg101@gmail.com>
@mozillazg mozillazg mentioned this issue Jan 15, 2023
Merged
znewman01 pushed a commit that referenced this issue Jan 15, 2023
@mozillazg
Add oci.Signature() method to expose raw signature (#2628)
29360f6 
Closes #2517

Signed-off-by: mozillazg <mozillazg101@gmail.com>

Signed-off-by: mozillazg <mozillazg101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add oci.Signature() method to expose raw signature mozillazg/cosign
1 participant
@haydentherapper