Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cosign policy command #2836

Closed
rdimitrov opened this issue Mar 24, 2023 · 5 comments · Fixed by #2846
Closed

Remove cosign policy command #2836

rdimitrov opened this issue Mar 24, 2023 · 5 comments · Fixed by #2846
Labels
enhancement New feature or request

Comments

@rdimitrov
Copy link
Contributor

Description

Hey, based on the discussions in sigstore/sigstore#737 (ref. sigstore/sigstore#737 (comment)) is it right to assume that the cosign policy command should be deprecated since the code it depends on is going to be removed too?

Thanks in advance 👍

@rdimitrov rdimitrov added the enhancement New feature or request label Mar 24, 2023
@znewman01
Copy link
Contributor

CC @asraa @priyawadhwa

I believe that's the case, as I don't know that anybody actually uses this feature. We should ask around a little first.

@rdimitrov
Copy link
Contributor Author

Thanks, Zack 👍

I already had a branch (dimitrovr/remove-policy) with removing it but we should see if all agree to deprecate it.

@asraa
Copy link
Contributor

asraa commented Mar 27, 2023

Yes - i don't think anyone uses this because I'm not even sure it works completely correctly at this moment.

@rdimitrov
Copy link
Contributor Author

Let me know when it's decided and I'll open a PR 👍

@znewman01
Copy link
Contributor

I think you can go for it, @rdimitrov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants