chore: remove cosign policy command #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2846 +/- ##
==========================================
+ Coverage 29.47% 30.32% +0.84%
==========================================
Files 151 149 -2
Lines 9678 9399 -279
==========================================
- Hits 2853 2850 -3
+ Misses 6386 6110 -276
Partials 439 439
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hectorj2f
approved these changes
Mar 28, 2023
normally, yes, but @asraa claims that it doesn't really work right now |
|
@rdimitrov can you add a note to that effect in the release notes? otherwise LGTM |
Sure, what would be the name of the next release as there's no template for it yet? If of course, I'm looking at the right place? 😃 |
haydentherapper
approved these changes
Apr 4, 2023
cpanato
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following PR removes the
cosign policycommand.It is motivated by the discussions in sigstore/sigstore#737 and it is a necessary step in order for sigstore/sigstore#737 to be merged.
Closes #2836
Release Note
Deprecated: Removed cosign policy command
Documentation