Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): add an example for existing option on verify-blob command #1024

Merged

Conversation

erkanzileli
Copy link
Contributor

Co-authored-by: Furkan Türkal furkan.turkal@trendyol.com
Co-authored-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Signed-off-by: Erkan Zileli erkan.zileli@trendyol.com

Summary

An existing option is documented with an example on the verify-blob command.

Ticket Link

Fixes

Release Note


@dekkagaijin
Copy link
Member

LGTM, please run go run -tags pivkey,pkcs11key,cgo ./cmd/help/ to resolve presubmit failure

Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>
Co-authored-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Signed-off-by: Erkan Zileli <erkan.zileli@trendyol.com>
@erkanzileli erkanzileli force-pushed the fix/verify-blob-document-update branch from d826be8 to 30caa51 Compare November 10, 2021 19:51
Copy link
Member

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dekkagaijin dekkagaijin merged commit 5a350e4 into sigstore:main Nov 10, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Nov 10, 2021
@cpanato cpanato modified the milestones: v1.4.0, v1.3.1 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants