Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate whole statement not just predicate part #1035

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Summary

validate whole statement not just predicate part

Ticket Link

Fixes #1012

Release Note

feat: validate whole statement not just predicate part

render1636653473904

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@dlorenc
Copy link
Member

dlorenc commented Nov 11, 2021

We'll merge after we cut the release to avoid screwing up release notes :)

Copy link
Member

@dekkagaijin dekkagaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@dlorenc dlorenc merged commit 84c94b6 into sigstore:main Nov 11, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the verify attestation implementation
3 participants