Remove img field from sigLayer #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mattmoor
reviewed
Nov 12, 2021
We can use the layer to get the payload, so we shouldn't need this field. The only thing we lose is that if the descriptor digest is wrong we don't catch that anymore. Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
priyawadhwa
force-pushed
the
remote-layer
branch
from
a624a02
to
f8d2551
Compare
dlorenc
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the already available Layer to get the payload, so we shouldn't need the
imgfield. The only thing we lose is that we no longer callimg.LayerByDigestso if the descriptor digest is invalid or doesn't match then we don't catch that anymore.