Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify-blob: make the signature flag mandatory #1045

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

shibumi
Copy link
Contributor

@shibumi shibumi commented Nov 12, 2021

Summary

Before this commit, the verify-blob command would fail ungracefully in experimental mode
if no signature has been provided. This commit adds a better fitting error message.

Before this change:
❯ COSIGN_EXPERIMENTAL=1  cosign verify-blob /tmp/hello-world.txt
Error: verifying blob [/tmp/hello-world.txt]: read .: is a directory
main.go:46: error during command execution: verifying blob [/tmp/hello-world.txt]: read .: is a directory
After this change:
❯ COSIGN_EXPERIMENTAL=1  cosign verify-blob /tmp/hello-world.txt
Error: verifying blob [/tmp/hello-world.txt]: missing flag '--signature'
main.go:46: error during command execution: verifying blob [/tmp/hello-world.txt]: missing flag '--signature'

Ticket Link

None

Release Note

Fixed: verify-blob error message for missing signature flag

Before this commit, the verify-blob command would fail ungracefully in experimental mode
if no signature has been provided. This commit adds a better fitting error message.

Signed-off-by: Christian Rebischke <chris@shibumi.dev>
@dlorenc dlorenc merged commit cd7e6a8 into sigstore:main Nov 12, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Nov 12, 2021
@shibumi shibumi deleted the shibumi/fix-make-signature-mandatory branch November 12, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants