fix: reproducible builds #1053
Merged
fix: reproducible builds #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2021
naveensrinivasan
added a commit
to ossf/scorecard
that referenced
this pull request
Nov 16, 2021
2 tasks
azeemshaikh38
pushed a commit
to ossf/scorecard
that referenced
this pull request
Nov 16, 2021
|
We should be good to merge if you get the DCO bit signed! |
|
oh, no idea why it didn't signoff :| |
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
dlorenc
approved these changes
Nov 21, 2021
|
thanks for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On #1019 there are some discussion about the builds not being reproducible.
We could also ditch the ldflags and read from
debug.ReadBuildInfo()only.What this PR does is:
The other bits goreleaser needs for reproducible builds are already there, so this should be working assuming the same inputs are given.
More info:
Ticket Link
Release Note