Kubernetes: set secret immutable by default for version >= 1.21 #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentrax
force-pushed
the
feature/immutable-secret
branch
from
adb3e2c
to
9e7ea70
Compare
|
Not sure whether setting immutable: true by default is good practice or not without passing smth like |
Dentrax
force-pushed
the
feature/immutable-secret
branch
from
9e7ea70
to
ad93a8d
Compare
hectorj2f
reviewed
Nov 22, 2021
pkg/cosign/kubernetes/client.go
Outdated
| @@ -57,3 +58,16 @@ func Client() (kubernetes.Interface, error) { | |||
| } | |||
| return kubernetes.NewForConfig(config) | |||
| } | |||
|
|
|||
| func CheckImmutableSecretSupported(client kubernetes.Interface) (bool, error) { | |||
There was a problem hiding this comment.
nit: It is been used internally in the package, func checkImm.....
Fixes sigstore#1090 Signed-off-by: Furkan <furkan.turkal@trendyol.com> Co-authored-by: Batuhan <batuhan.apaydin@trendyol.com> Co-authored-by: Erkan <erkan.zileli@trendyol.com>
Dentrax
force-pushed
the
feature/immutable-secret
branch
from
ad93a8d
to
870fce8
Compare
dlorenc
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1090
Signed-off-by: Furkan furkan.turkal@trendyol.com
Co-authored-by: Batuhan batuhan.apaydin@trendyol.com
Co-authored-by: Erkan erkan.zileli@trendyol.com