Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve perms, error handling #1151

Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix: improve perms, error handling #1151

merged 1 commit into from
Dec 7, 2021

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Dec 7, 2021

Summary

  • create certificates and signature with less permissions (0600 vs 0666 - the default of os.Create
  • improve error handling a bit by wrapping the errors

Ticket Link

n/a

Release Note

--output-signature and --output-certificate now created with 0600 permissions

@caarlos0
fix: improve perms, error handling
2b608c9 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@dekkagaijin dekkagaijin merged commit 96c02ba into sigstore:main Dec 7, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Dec 7, 2021
@caarlos0 caarlos0 deleted the perms branch December 7, 2021 01:30
@cpanato cpanato modified the milestones: v1.4.0, v1.4.1 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkagaijin dekkagaijin dekkagaijin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caarlos0 @dekkagaijin @cpanato