Allow fetching TUF root from HTTP #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is related to: #1179 |
hectorj2f
reviewed
Dec 10, 2021
There was a problem hiding this comment.
@rgerganov You are also missing to update the command description to be able to use a different mirror in cmd/cosign/cli/initialize.go:
SigStore remote TUF repository is pulled from the GCS mirror at sigstore-tuf-root.
hectorj2f
reviewed
Dec 10, 2021
This description is about the default behavior which is not changed (i.e. pulling from GCS) |
asraa
approved these changes
Dec 10, 2021
This patch allows fetching TUF root from HTTP in addition to GCS. If the specified mirror is an HTTP link, then HTTPRemoteStore will be used. Otherwise it defaults to GCS. Signed-off-by: Radoslav Gerganov <rgerganov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows fetching TUF root from HTTP in addition to GCS. If the
specified mirror is an HTTP link, then HTTPRemoteStore will be used.
Otherwise it defaults to GCS.