create mutate functions for oci.Signature
#1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekkagaijin
force-pushed
the
mutate-sig
branch
2 times, most recently
from
643bbda
to
62cf479
Compare
mattmoor
reviewed
Dec 14, 2021
pkg/oci/mutate/signature.go
Outdated
Comment on lines
127
to
128
| // SignatureAnnotations returns a new `oci.Signature` based on the provided one | ||
| func SignatureAnnotations(sig oci.Signature, newAnnotations map[string]string) (oci.Signature, error) { |
There was a problem hiding this comment.
I wonder if we should expose mutate.Signature(sig, opts...) with functional options for fiddling with the individual properties. This would let us batch a set of alterations together and feels less verbose 🤔
There was a problem hiding this comment.
Thought about that; we'd have to either expose the static.Options or create new ones here. I'd be OK with having a common options folder
mattmoor
approved these changes
Dec 14, 2021
dekkagaijin
force-pushed
the
mutate-sig
branch
from
6e65fbd
to
4c815bc
Compare
added 4 commits
December 14, 2021 15:27
Signed-off-by: Jake Sanders <jsand@google.com>
Signed-off-by: Jake Sanders <jsand@google.com>
Signed-off-by: Jake Sanders <jsand@google.com>
Signed-off-by: Jake Sanders <jsand@google.com>
dekkagaijin
force-pushed
the
mutate-sig
branch
from
4c815bc
to
cd447e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
#844
Release Note