New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create `DSSEAttestor` interface, `payload.DSSEAttestor` implementation #1221

Merged

dekkagaijin merged 9 commits into sigstore:main from dekkagaijin:merge-me-matt

Dec 16, 2021

Member

dekkagaijin commented Dec 15, 2021

This is the Attestor equivalent of the previous Signer refactoring, plus nips and tucks here and there

TODO:

implement the rest of the attestors
move over fulcio operations into their respective Signer and DSSEAttestor implementations, stop using the fulcio signature.Signer
perform all signing and attestation operations via new /pkg libraries

Ticket Link

Release Note

NONE

Jake Sanders added 3 commits

December 15, 2021 10:53


          rename Signer files

2472e94

Signed-off-by: Jake Sanders <jsand@google.com>


          create DSSEAttestor interface

8c9b905

Signed-off-by: Jake Sanders <jsand@google.com>


          create payload.DSSEAttestor

9785ce0

Signed-off-by: Jake Sanders <jsand@google.com>

dekkagaijin requested a review from mattmoor

December 15, 2021 20:24

mattmoor reviewed

View reviewed changes

internal/pkg/cosign/payload/attestor.go Outdated Show resolved Hide resolved

mattmoor reviewed

View reviewed changes

internal/pkg/cosign/payload/signer.go Outdated Show resolved Hide resolved

mattmoor reviewed

View reviewed changes

internal/pkg/cosign/payload/attestor.go Show resolved Hide resolved

mattmoor reviewed

View reviewed changes

internal/pkg/cosign/payload/signer.go Outdated Show resolved Hide resolved

mattmoor reviewed

View reviewed changes

internal/pkg/cosign/payload/signer.go Show resolved Hide resolved

mattmoor reviewed

View reviewed changes

internal/pkg/cosign/payload/signer.go Outdated Show resolved Hide resolved

Jake Sanders added 6 commits

December 15, 2021 15:24


          consolidate Sign and PublicKey options

28942cc

Signed-off-by: Jake Sanders <jsand@google.com>


          remove pae variable

fd6c64c

Signed-off-by: Jake Sanders <jsand@google.com>


          provide payload bytes directly to signPayload

9ab8e7b

Signed-off-by: Jake Sanders <jsand@google.com>


          don't inline payloadSigner

00a1a0e

Signed-off-by: Jake Sanders <jsand@google.com>


          unNeceSSarRy LeAdIng WhitESpaCe

7e975f6

Signed-off-by: Jake Sanders <jsand@google.com>


          split signing and public key retrieval

6ca3b3e

Signed-off-by: Jake Sanders <jsand@google.com>

mattmoor approved these changes

View reviewed changes

dekkagaijin merged commit acf5900 into sigstore:main

dekkagaijin deleted the merge-me-matt branch

December 16, 2021 00:17

github-actions bot added this to the v1.5.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment