Log the proper remote repo for the signatures on verify #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
approved these changes
Dec 22, 2021
Currently we print the image repo being signed as if we were pushing the signatures to that same repo, which could lead to users being surprised. Instead try to get the override and print that instead Resolves: sigstore#1242 Signed-off-by: Itxaka <igarcia@suse.com>
Itxaka
force-pushed
the
output_signature_overrideRepo
branch
from
18445b9
to
c7d3ba7
Compare
|
woops sorry, I thought the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we print the image repo being signed as if we were pushing the
signatures to that same repo, which could lead to users being surprised.
Instead try to get the override and print that instead
Ticket Link
Resolves: #1242
Release Note