Fix semantic bugs in attestation verifification. #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar to #1248 but reverse. |
DSSE requires that the payload types match, but the Attestation spec requires that the payload type be the specific in-toto one. We don't actually do anything with the content here other than dump it in plain text, but semantically we're calling these attestations in the CLI so we should enforce that part of the specification as well. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
loosebazooka
approved these changes
Dec 24, 2021
| payload, err := att.Payload() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| env := ssldsse.Envelope{} | ||
| if err := json.Unmarshal(payload, &env); err != nil { | ||
| return nil | ||
| return err |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSSE requires that the payload types match, but the Attestation
spec requires that the payload type be the specific in-toto one. We
don't actually do anything with the content here other than dump it
in plain text, but semantically we're calling these attestations in the
CLI so we should enforce that part of the specification as well.
Signed-off-by: Dan Lorenc lorenc.d@gmail.com
Summary
Ticket Link
Fixes
Release Note