Update SBOM spec to indicate compat for syft #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documents the support for syft json added in sigstore#1137 Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
|
Thanks! I'd be happy to move these specifications somewhere else to make "governance" by all the implementing parties easier at some point. |
dlorenc
approved these changes
Jan 6, 2022
|
@dlorenc please don't merge. I have one more minor change to make. EDIT - should be good to go now. |
As noted by @VinodAnandan - the previous message may have caused confusion about NTIA recorgnized formats v/s formats cosign uses. Updating the wording to explicitly call out cosign supported formats. Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
developer-guy
approved these changes
Jan 6, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Update SBOM spec to indicate compat for syft This documents the support for syft json added in sigstore#1137 Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net> * Reword SBOM wording to indicate that the formats are cosign specific As noted by @VinodAnandan - the previous message may have caused confusion about NTIA recorgnized formats v/s formats cosign uses. Updating the wording to explicitly call out cosign supported formats. Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the support for syft json added in #1137
Signed-off-by: Sambhav Kothari skothari44@bloomberg.net
Summary
cosign already supports syft as an sbom format in #1137 but the spec was not updated to capture this support. This is a simple doc/spec change to bring it in line with the CLI.
Ticket Link
Fixes
Release Note