Fix a few bugs in cosign initialize #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing on just windows, gotta fix that |
Maybe useful- files seem to silently get converted to /r/n line endings when accessed on windows, even from the embedded data I had to jump through some hoops to convert back before checking signatures. |
asraa
approved these changes
Jan 7, 2022
asraa
reviewed
Jan 7, 2022
haydentherapper
force-pushed
the
fix-tuf
branch
from
cf7e7d6
to
72cdb43
Compare
* In getRoot, the metadata is always stored at the top level, not under repository/. * In Initialize, download all metadata and targets. This should avoid a disk write on verify. * Use path instead of filepath for Windows Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
fix-tuf
branch
from
72cdb43
to
d442fa7
Compare
|
Thanks! Nicely done. |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* In getRoot, the metadata is always stored at the top level, not under repository/. * In Initialize, download all metadata and targets. This should avoid a disk write on verify. * Use path instead of filepath for Windows Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not under repository/. This resulted in initialize always falling
back to the embedded root.
avoid a disk write on verify.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note