-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --timeout
support to sign
command
#1379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice
Looks like you have to run |
db43155
to
c411c91
Compare
Updated the PR, while we now can replace other |
Nice! Sorry I missed the "Approve and Run" thing here again. |
@saschagrunert, there are some errors. Can you take a look? |
We can now specify a global `-t`/`--timeout` option to specify a timeout for any command. It is implemented for `sign` for now, which resolves a leftover `TODO`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
c411c91
to
bea919f
Compare
Yes, sure. The unit tests seemed to be a flake but I fixed the e2e tests. Can you please re-trigger the CI? |
ready @dlorenc |
We can now specify a global `-t`/`--timeout` option to specify a timeout for any command. It is implemented for `sign` for now, which resolves a leftover `TODO`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
We can now specify a global `-t`/`--timeout` option to specify a timeout for any command. It is implemented for `sign` for now, which resolves a leftover `TODO`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Summary
We can now specify a global
-t
/--timeout
option to specify a timeout for any command. It is implemented forsign
for now, which resolves a leftoverTODO
.As a follow-up we can consider adding support to other commands as well.
Ticket Link
None
Release Note