Add --timeout support to sign command
#1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you have to run |
saschagrunert
force-pushed
the
timeout
branch
from
db43155
to
c411c91
Compare
|
Updated the PR, while we now can replace other |
|
Nice! Sorry I missed the "Approve and Run" thing here again. |
|
@saschagrunert, there are some errors. Can you take a look? |
We can now specify a global `-t`/`--timeout` option to specify a timeout for any command. It is implemented for `sign` for now, which resolves a leftover `TODO`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
timeout
branch
from
c411c91
to
bea919f
Compare
Yes, sure. The unit tests seemed to be a flake but I fixed the e2e tests. Can you please re-trigger the CI? |
cpanato
approved these changes
Feb 2, 2022
|
ready @dlorenc |
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
We can now specify a global `-t`/`--timeout` option to specify a timeout for any command. It is implemented for `sign` for now, which resolves a leftover `TODO`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
We can now specify a global `-t`/`--timeout` option to specify a timeout for any command. It is implemented for `sign` for now, which resolves a leftover `TODO`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can now specify a global
-t/--timeoutoption to specify a timeout for any command. It is implemented forsignfor now, which resolves a leftoverTODO.As a follow-up we can consider adding support to other commands as well.
Ticket Link
None
Release Note