Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a newline after password input #1407

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Add a newline after password input #1407

merged 1 commit into from
Feb 6, 2022

Conversation

knqyf263
Copy link
Contributor

@knqyf263 knqyf263 commented Feb 6, 2022

Summary

There is no newline after entering a password and the output is hard to read.

Before:

$ cosign sign --key cosign.key knqyf263/cosign-test
an error occurred: no provider found for that key reference, will try to load key from disk...
Enter password for private key: Pushing signature to: index.docker.io/knqyf263/cosign-test

After:

$ cosign sign --key cosign.key knqyf263/cosign-test
an error occurred: no provider found for that key reference, will try to load key from disk...
Enter password for private key:
Pushing signature to: index.docker.io/knqyf263/cosign-test

Release Note

Add a newline after entering password

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@cpanato cpanato requested a review from dlorenc February 6, 2022 09:46
@dlorenc dlorenc merged commit 5efee8a into sigstore:main Feb 6, 2022
@github-actions github-actions bot added this to the v1.6.0 milestone Feb 6, 2022
@knqyf263 knqyf263 deleted the fix/password_new_line branch February 9, 2022 17:31
hatmarch pushed a commit to hatmarch/cosign that referenced this pull request Apr 19, 2022
Signed-off-by: knqyf263 <knqyf263@gmail.com>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants