Remove TUF timestamp from OCI signature bundle #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in sigstore#1273, this solution does not work because the TUF root is not included in the snapshot. Removing unused code. Confirmed that verifying images with a timestamp annotation still works. Confimed that signing and verifying works locally too. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
How to pad your github stats - Add a feature and remove it a week later |
dlorenc
approved these changes
Feb 9, 2022
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
As described in sigstore#1273, this solution does not work because the TUF root is not included in the snapshot. Removing unused code. Confirmed that verifying images with a timestamp annotation still works. Confimed that signing and verifying works locally too. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
As described in sigstore#1273, this solution does not work because the TUF root is not included in the snapshot. Removing unused code. Confirmed that verifying images with a timestamp annotation still works. Confimed that signing and verifying works locally too. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1273, this solution does not work
because the TUF root is not included in the snapshot.
Removing unused code.
Confirmed that verifying images with a timestamp
annotation still works. Confimed that signing and
verifying works locally too.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note