Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance clean cmd capability #1430

Merged
merged 1 commit into from Feb 9, 2022

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Summary

To let people specify which tag type they want to delete from an image, .sig or .att or both.

Ticket Link

Fixes #1425

Release Note

feat: enhance clean cmd capability

@developer-guy developer-guy force-pushed the feature/1425 branch 2 times, most recently from a4f8a78 to f0de467 Compare February 9, 2022 07:20
@developer-guy developer-guy self-assigned this Feb 9, 2022
@developer-guy developer-guy force-pushed the feature/1425 branch 2 times, most recently from b6384e7 to 1c72c23 Compare February 9, 2022 08:52
test/e2e_test.go Outdated Show resolved Hide resolved
@dlorenc
Copy link
Member

dlorenc commented Feb 9, 2022

Looks like we currently get an error if one of the types is not present:
image

We should probably allow that and continue.

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@dlorenc dlorenc merged commit 3adff46 into sigstore:main Feb 9, 2022
@github-actions github-actions bot added this to the v1.6.0 milestone Feb 9, 2022
hatmarch pushed a commit to hatmarch/cosign that referenced this pull request Apr 19, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance capabilities of clean command by specifying intent explicitly
2 participants