Fix linter error on main #1484
Merged
Fix linter error on main #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
approved these changes
Feb 18, 2022
cpanato
approved these changes
Feb 18, 2022
nsmith5
approved these changes
Feb 18, 2022
priyawadhwa
added a commit
to priyawadhwa/cosign
that referenced
this pull request
Feb 18, 2022
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
dlorenc
added a commit
that referenced
this pull request
Feb 18, 2022
* Merge pull request from GHSA-ccxc-vr6p-4858 * Make sure signature in Rekor bundle matches signature being verified Signed-off-by: Priya Wadhwa <priya@chainguard.dev> * Only print "fulcio verified" when using Fulcio Currently we tell users that we've verified against the Fulcio root trust when verifying but this isn't always true. This work ensures we only say this when we actually use the Fulcio root cert for verification. Signed-off-by: Nathan Smith <nathan@chainguard.dev> * Add e2e test Signed-off-by: Nathan Smith <nathan@chainguard.dev> Co-authored-by: Priya Wadhwa <priya@chainguard.dev> * fix lint (#1484) Signed-off-by: Priya Wadhwa <priya@chainguard.dev> * Manual merge conflict resolution in e2e_test. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com> Co-authored-by: Nathan Smith <12156185+nsmith5@users.noreply.github.com> Co-authored-by: Dan Lorenc <lorenc.d@gmail.com>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Priya Wadhwa priya@chainguard.dev
Summary
Ticket Link
Fixes
Release Note