Pick up some of the shared workflows #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using this downstream, and it is a nice way of getting a whole bunch of information from the KinD cluster on failures to debug things. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
dlorenc
approved these changes
Feb 21, 2022
|
I think we should probably snap a |
cpanato
reviewed
Feb 22, 2022
.github/workflows/donotsubmit.yaml
Outdated
| -level="error" | ||
|
|
||
| echo '::endgroup::' | ||
| uses: chainguard-dev/actions/donotsubmit@main |
There was a problem hiding this comment.
can we use a git hash instead of main?
|
@mattmoor, we need to add the following in the dependabot.yml definition - package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"then it will check the actions/jobs and update them according |
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
|
Added the dependabot config as well. |
cpanato
reviewed
Feb 22, 2022
cpanato
reviewed
Feb 22, 2022
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
cpanato
approved these changes
Feb 22, 2022
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
* Use a shared action for dumping KinD diagnostics and DO NOT SUBMIT. We've been using this downstream, and it is a nice way of getting a whole bunch of information from the KinD cluster on failures to debug things. Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Add the nodiff action to the party Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Start to consume the whitespace actions Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Start to consume the go formatting actions Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Pin SHAs Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Add dependabot config for bumping actions Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Add newline at EOF Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Use a shared action for dumping KinD diagnostics and DO NOT SUBMIT. We've been using this downstream, and it is a nice way of getting a whole bunch of information from the KinD cluster on failures to debug things. Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Add the nodiff action to the party Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Start to consume the whitespace actions Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Start to consume the go formatting actions Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Pin SHAs Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Add dependabot config for bumping actions Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Add newline at EOF Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up a shared definition of
DO NOT SUBMITto avoid divergent shell code.This also picks up our KinD diagnostic dumping logic from downstream, which we've been using to debug assorted KinD-based failures.
I have a few more workflows on my list that we can share this way, and I'll likely keep adding them here.
@cpanato Not sure what the best way of getting this to use the dependabot form is, so PTAL and LMK how best to adjust this. We haven't cut a release yet, but we can once we've gotten a bunch more of our workflows shared this way.
Ticket Link
N/A
Release Note