Add CertExtensions func to extract all extensions #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
asraa
reviewed
Feb 25, 2022
There was a problem hiding this comment.
Hey just curious! Do you actually see extensions for trigger and sha on fulcio issued certs in the last few weeks?
(see sigstore/fulcio#437)
|
@asraa Yes, I signed some stuff earlier this day with GH and all extensions added with sigstore/fulcio#306 where there. |
dlorenc
approved these changes
Feb 25, 2022
JimBugwadia
approved these changes
Feb 25, 2022
Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
dlorenc
approved these changes
Feb 26, 2022
coyote240
pushed a commit
to coyote240/cosign
that referenced
this pull request
Mar 1, 2022
* Add CertExtensions func to extract all extensions Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de> * Renamed issuer to oidcIssuer Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Add CertExtensions func to extract all extensions Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de> * Renamed issuer to oidcIssuer Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Kotzbauer git@ckotzbauer.de
Summary
This adds a
CertExtensionsfunction to the signature package to extract all extensions from a cert and return them as map. The map-key is either a human-readable name or the extensionID (if no name is specified in the mapping).I did not remove the
CertIssuerExtensionfunc for backward compatibility.Ticket Link
close #1456
Release Note
/cc @JimBugwadia