Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cosigned validation error messages #1618

Merged
merged 1 commit into from Mar 16, 2022
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 16, 2022

Summary

  • improve cosigned validation error messages

Ticket Link

Fixes #1607

Release Note

improve cosigned validation error messages

@cpanato cpanato requested review from mattmoor and vaikas March 16, 2022 14:25
@cpanato cpanato closed this Mar 16, 2022
@cpanato cpanato reopened this Mar 16, 2022
@cpanato
Copy link
Member Author

cpanato commented Mar 16, 2022

there is a GitHub incident opened

@cpanato cpanato force-pushed the GH-1607 branch 2 times, most recently from 5f4ec33 to 62c4a80 Compare March 16, 2022 15:32
Signed-off-by: cpanato <ctadeu@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #1618 (04877f4) into main (f8a6bad) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   27.95%   27.99%   +0.03%     
==========================================
  Files         137      137              
  Lines        7826     7826              
==========================================
+ Hits         2188     2191       +3     
+ Misses       5407     5405       -2     
+ Partials      231      230       -1     
Impacted Files Coverage Δ
...cosigned/v1alpha1/clusterimagepolicy_validation.go 88.34% <100.00%> (+2.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a6bad...04877f4. Read the comment docs.

@mattmoor mattmoor merged commit b981eb6 into sigstore:main Mar 16, 2022
@cpanato cpanato deleted the GH-1607 branch March 16, 2022 18:23
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosigned error validation messages could be improved
5 participants