Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove replace directive #1669

Merged
merged 1 commit into from
Mar 28, 2022
Merged

remove replace directive #1669

merged 1 commit into from
Mar 28, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 28, 2022

  • remove replace directive

But also not sure if this is all we need

Will fix #1555 when we release

TODO as follow up

  • add tests for 1.23 k8s

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato marked this pull request as ready for review March 28, 2022 14:24
@dlorenc
Copy link
Member

dlorenc commented Mar 28, 2022

Should we cut a 1.6.1 after this?

@dlorenc dlorenc merged commit 69fc348 into sigstore:main Mar 28, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 28, 2022
@cpanato cpanato deleted the remove-replace branch March 28, 2022 16:03
@cpanato
Copy link
Member Author

cpanato commented Mar 28, 2022

why not 1.7.0? @dlorenc

@dlorenc
Copy link
Member

dlorenc commented Mar 28, 2022

why not 1.7.0? @dlorenc

works for me!

@cpanato
Copy link
Member Author

cpanato commented Mar 28, 2022

will prepare the changelog

priyawadhwa pushed a commit to priyawadhwa/cosign that referenced this pull request Mar 28, 2022
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with installing https://github.com/sigstore/cosign/releases/tag/v1.6.0
4 participants