Refactor based on discussions in #1650 #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
|
@mattmoor @hectorj2f |
mattmoor
reviewed
Mar 28, 2022
| // at authority.Sources to determine additional information for the | ||
| // WithRemoteOptions below, at least the 'TargetRepository' | ||
| // https://github.com/sigstore/cosign/issues/1651 | ||
| opts := ociremote.WithRemoteOptions(remote.WithAuthFromKeychain(kc)) |
There was a problem hiding this comment.
Should we also include the ociremote.Option argument from above?
There was a problem hiding this comment.
Sure, it's never currently used, so just left it in the TODO, but done :)
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
mattmoor
approved these changes
Mar 28, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1674 +/- ##
==========================================
+ Coverage 29.20% 29.25% +0.05%
==========================================
Files 140 140
Lines 8340 8346 +6
==========================================
+ Hits 2436 2442 +6
Misses 5639 5639
Partials 265 265
Continue to review full report at Codecov.
|
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Refactor based on discussions in sigstore#1650 Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * Simplify return signature. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * pr feedback. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * remove now unnecessary var. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Refactor code based on discussions in #1650 as followups.
Ticket Link
Fixes
Release Note