verify: remove extra calls to rekor for verify and verify-blob #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
dlorenc
approved these changes
Mar 31, 2022
|
cc @rohankh532 this makes |
Codecov Report
@@ Coverage Diff @@
## main #1694 +/- ##
==========================================
- Coverage 29.43% 29.37% -0.06%
==========================================
Files 141 141
Lines 8413 8429 +16
==========================================
Hits 2476 2476
- Misses 5668 5684 +16
Partials 269 269
Continue to review full report at Codecov.
|
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…ore#1694) * remove extra calls to rekor for verify-blob Signed-off-by: Asra Ali <asraa@google.com> * fix hex output for uuid Signed-off-by: Asra Ali <asraa@google.com> * fix lint Signed-off-by: Asra Ali <asraa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Summary
Removes extra calls to Rekor during verification:
When verifying a blob, we retrieve the entry UUIDs (by an artifact hash search), and then call
verifyRekorEntry, which then takes the (cert, pubkey, artifact) and makes a call to rekor to get the entry. Instead, we pass the entry since we already have it.Distangles VerifyTLogEntry from inside of FindTlogEntry. Users can call this directly. This means that we don't need to
FindTlogEntryto verify it if we already have it, which saves the call from (1).In both
verifyandverify-blob, we callverifyRekorEntry, which has ANOTHER call toGetTlogEntryafterFindTlogEntryto get the actual entry, we already got it! RefactoredFindTlogEntryto give you back the... entry.Move the UUID verification into functions that are asking for an entry by UUID (e.g. when you get or find an entry)
Ticket Link
Fixes
Release Note